Repository navigation
feat: build one client per rollout, share renderers process-wide #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ce9eb90
feat: build one client per rollout, share renderers process-wide
mikasenghaas 643c21f
feat: match OpenAI SDK transport defaults, no client retries
mikasenghaas 1225f88
Merge branch 'main' into feat/per-rollout-clients
mikasenghaas 52a8272
feat: elastic renderer pool, sized by a multiplex knob
mikasenghaas fcdc59c
docs: drop the model-client paragraph from Borrowed Resources
mikasenghaas 2d80d69
chore: drop transport-settings comment from EvalClient
mikasenghaas 13e0def
fix: dedup only version-shaped segments in the upstream URL join
mikasenghaas 32933a7
refactor: lift the upstream URL join into clients.client.join_url
mikasenghaas 292aeca
chore: public VERSION_SEGMENT, trim the join_url docstring
mikasenghaas cedc939
refactor: move transport settings and build_async_openai to clients.c…
mikasenghaas 30c071f
chore: drop seat-resolution comment in Env
mikasenghaas b491474
refactor: client utils into clients.base, multiplex out of the pool key
mikasenghaas 69c0a50
fix: annotate ElasticRendererPool._shared as ClassVar (RUF012)
mikasenghaas a0d057a
fix: recover from a warm task cancelled by a dead event loop
mikasenghaas ae0da58
chore: log a failed warm at debug, drop unused contextlib import
mikasenghaas 0b25aa2
docs: give the client example its own section
mikasenghaas f36f6cf
chore: shorten the transport-defaults comment
mikasenghaas 339fb37
feat: elastic renderer pool, aligned with the interception pool
mikasenghaas d3d27b1
chore: no underscore methods on ElasticRendererPool
mikasenghaas 62ba589
feat: bare renderers with slot-owned locking
mikasenghaas 480aa7a
chore: name the pool registry _pools
mikasenghaas 7780331
feat: process-shared renderer list, pools as cheap views
mikasenghaas 6449686
chore: inline _pool_for at its call sites
mikasenghaas 4e8e91c
chore: trim client docstrings, fix multiplex doc, drop dead code
mikasenghaas b6b0e0c
Merge branch 'main' into feat/per-rollout-clients
mikasenghaas 01f3a3e
chore: drop the session client docstring
mikasenghaas c7c19d2
fix: close the legacy server's cached v0 clients on shutdown
mikasenghaas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.