Skip to content

chore: guard the v0 legacy bridge against non-renderer training clients #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikasenghaas merged 1 commit into from
Jun 10, 2026
Merged

chore: guard the v0 legacy bridge against non-renderer training clients #1613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions verifiers/v1/legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import zmq
import zmq.asyncio

from verifiers.v1.clients.config import ClientConfig
from verifiers.v1.clients.config import ClientConfig, RendererClientConfig
from verifiers.v1.serve.server import EnvServer
from verifiers.v1.serve.types import (
RunGroupRequest,
Expand Down Expand Up @@ -299,17 +299,23 @@ def _v0_client(self, client_config: ClientConfig, model: str):
``renderer_model_name`` (the base model) so a LoRA adapter name — served only for
sampling — never drives tokenizer loading; the per-request ``model`` still selects
the sampling target in ``run_rollout``."""
renderer_model = getattr(client_config, "renderer_model_name", None) or model
if not isinstance(client_config, RendererClientConfig):
raise ValueError(
"the v0 legacy bridge trains through a renderer (token-in/out) client, "
f"got client type {client_config.type!r}; MITO (chat-completions) "
"training of v0 envs is not supported"
)
renderer_model = client_config.renderer_model_name or model
key = (client_config.model_dump_json(), renderer_model)
if key not in self._clients:
from verifiers.clients import resolve_client
from verifiers.types import ClientConfig as V0ClientConfig

v0_config = V0ClientConfig(
client_type="renderer",
renderer_config=getattr(client_config, "renderer", None),
renderer_config=client_config.renderer,
renderer_model_name=renderer_model,
renderer_pool_size=getattr(client_config, "pool_size", None),
renderer_pool_size=client_config.pool_size,
api_base_url=client_config.base_url,
api_key_var=client_config.api_key_var,
extra_headers=dict(client_config.headers or {}),
Expand Down
Loading