Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build vLLM multimodal features as native kwargs items and placeholder ranges. Server callers can pass them directly to
mm_input; the token-generation HTTP client serializes them only when constructing its request. This removes the encode/decode round trip in prime-rl #3660 and consolidates the repeated hashes/placeholder assembly across model families.Qwen3-VL, Qwen3.5, Gemma 4, and Nemotron 3.5 use the same field factories and tensor layouts. The HTTP request format stays the same. The public helper is
renderers.client.build_mm_features.Validation: 26 client tests passed; six vLLM-dependent tests were skipped on macOS. A CPU probe using the actual vLLM 0.31.0 field types and Qwen field factory verified native tensors, hashes, and placeholder ranges for all four renderer classes without importing the serialization module. Ruff passed; the repository's type check completed with its configured advisory diagnostics. No live engine was run.
Note
Build native multimodal kwargs before HTTP serialization in
renderers.clientModel-specific multimodal builders (
_build_qwen_vl_kwargs,_build_gemma4_kwargs,_build_nemotron35_kwargs) in client.py now return nativeMultiModalKwargsItemsinstead of serialized feature payloads. Hash and placeholder assembly plus kwargs-item encoding moved intogenerate, so serialization happens once at the HTTP-client boundary. An empty encoded kwargs mapping is sent asNone.generate's payload instead.Macroscope summarized a3c71b3.