Repository navigation
feat(sandboxes): volume size at create + resize (ENG-7269) - #1132
Merged
Merged
Conversation
akirillo
requested review from
DamianB-BitFlipper,
JannikSt,
JohannesHa,
burnpiro,
cabrinha,
eexwhyzee,
kcoopermiller,
kennethnym,
mrmoxon and
willccbb
as code owners
October 30, 2026 20:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DamianB-BitFlipper
approved these changes
Nov 2, 2026
This was referenced Nov 2, 2026
mikasenghaas
pushed a commit
to PrimeIntellect-ai/verifiers
that referenced
this pull request
Nov 2, 2026
## Summary - Raise the `prime-sandboxes` floor from `>=0.5.3` to `>=0.5.4` and relock (`uv.lock`: 0.5.3 → 0.5.4). No other lock changes. ### SDK changes pulled in (0.5.3 → 0.5.4) - **feat(sandboxes): volume size at create + grow** (PrimeIntellect-ai/prime#1132, released in PrimeIntellect-ai/prime#1144). `volumes.create(name, size_gb=N)` sets a volume's capacity (100 GiB–10 TiB, default 100 GiB), `volumes.grow(name, size_gb)` grows it, and `Volume.size_gb` reports it. Additive only; verifiers needs no code change. ## Verification - `uv lock --check` passes; the `uv.lock` diff touches only `prime-sandboxes` (version + sdist/wheel URLs). - Standalone venv with `prime-sandboxes==0.5.4`: `Volume.size_gb` present; `Volumes.grow(name, size_gb)` and `AsyncVolumes.grow` exist. - `ty check verifiers` passes. - `pytest tests/unit -k "prime or runtime"` (macOS): 49 passed, 1 skipped; the 9 live `[prime]` runtime tests need a valid `PRIME_API_KEY` and were not run here. Full `uv sync` isn't possible on macOS because `onnxruntime` 1.29.0 in the lock ships linux-only wheels (pre-existing on main, unrelated; CI runs on ubuntu).
mikasenghaas
pushed a commit
to PrimeIntellect-ai/prime-rl
that referenced
this pull request
Nov 2, 2026
## Summary - Raise the `prime` floor from `>=0.18.0` to `>=0.19.2` and relock (`uv.lock`: `prime` 0.18.0 → 0.19.2, `prime-sandboxes` 0.5.3 → 0.5.4). No other lock changes. ### CLI/SDK changes pulled in - **feat(sandboxes): volume size at create + grow** (PrimeIntellect-ai/prime#1132, released in PrimeIntellect-ai/prime#1144). `prime sandbox volumes create --size-gb N`, `prime sandbox volumes grow NAME --size-gb N`, and SDK `volumes.create(size_gb=)` / `volumes.grow()`. Additive only. - `prime` 0.19.0–0.19.1 (localhost forwards, pause/resume, 24h live-process fix) are already covered by `prime-sandboxes` 0.5.3 from #4368, which merged before this branch was cut — no overlap with it. Companion: PrimeIntellect-ai/verifiers#3045 (prime-sandboxes 0.5.4). ## Verification - `uv lock --check` passes (uv 0.12.3 and 0.13.6); `uv sync --all-extras --all-packages --locked` succeeds (resolves `prime` 0.19.2 + `prime-sandboxes` 0.5.4). - Standalone venv with 0.5.4: `Volume.size_gb` present; `Volumes.grow(name, size_gb)` exists. - `pytest tests/unit --ignore=tests/unit/train -m "not gpu"` (macOS): 737 passed, 1 skipped, 1 xfailed, 7 failed. The 7 failures (inference/orchestrator/transports) reproduce identically on `origin/main` in the same env — pre-existing, unrelated. 5 modules skipped at collection (missing linux-only `vllm`/`fla`/`prime_kernels`; CI runs on ubuntu).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK + CLI for user-specified sandbox volume size (ENG-7269). Server side: PrimeIntellect-ai/platform#7218.
volumes.create(name, size_gb=...)andvolumes.grow(name, size_gb)(sync + async;PATCH /sandbox/volumes/{name}, returns the updatedVolume).Volume.size_gb(optional; absent from older servers).prime sandbox volumes create --size-gb N(also with--from), newprime sandbox volumes grow NAME --size-gb N, capacity shown in list/get.Merge order: release only after platform#7218 is deployed; older servers reject the
size_gbfield / PATCH route.No version bump (release PR convention). Pre-existing failures in
packages/prime/testson cleanmainare unrelated.