Skip to content

feat: non-blocking, concurrent prime uploads - #4363

Merged
mikasenghaas merged 9 commits into
mainfrom
feat/sdk-upload-perf
Nov 3, 2026
Merged

mikasenghaas merged 9 commits into
mainfrom
feat/sdk-upload-perf

Conversation

@mikasenghaas

@mikasenghaas mikasenghaas commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

Prime uploads keep up with the orchestrator, and logging to Prime never blocks it. Companion to PrimeIntellect-ai/prime#1136.

  • SDK pin. prime-runs[train]>=0.1.6, which pulls prime-traces 0.0.12 from PyPI. These releases contain feat: non-blocking, concurrent run uploads in prime-runs and prime-traces prime#1136: gzip level 1, up to 8 upload requests in flight, an upload queue bounded by records whose submit never blocks, and lazily built upload records.
    • uv.lock is written with uv 0.12.0 (lockfile revision 3); only the two SDK packages change.
  • No thread hop for Prime. PrimeMonitor calls run.log_metrics and run.log_episodes directly on the event loop, not through asyncio.to_thread. A queue put that never blocks needs no thread, and each hop had to win the GIL back from the uploader thread.
  • A production-sized load test. tests/unit/monitors/test_monitor_load.py:
    • Episode sizes: episodes draw their size from a lognormal fitted to a production RL run (median 6.4 MB, p90 17 MB; it also matches the mean of 8.5 MB and the p99 of 35 MB), capped at 60 MB. 1,000 episodes is ~8 GB of JSON, close to one production step of 1,024 samples.
    • Memory: episodes share 24 traces at log-spaced sizes, so the test's own memory stays small.
    • Fake endpoint: the fake Traces endpoint gzips at the SDK's level and counts lines under a lock, because the client now sends several requests at once.
    • File monitor check: it streams every trace chunk, since 8 GB spans two 5 GiB chunks.
    • No expected failure: the prime monitor at 1,000 episodes is no longer marked as one.
    • A separate log() limit of 1 s. A log() call may await the monitor's own work: the file monitor awaits its write, which encodes the episode on a worker thread, while the event loop keeps serving other tasks. The lag limits still cover the loop.
    • The p99 lag limit rises from 50 to 100 ms. At production sizes the file monitor encodes each episode in one call, which stalls the event loop with a p99 of ~60 ms on CI. Main's code shows the same stall with this test. feat: encode episodes for the file and prime monitors one node at a time #4366 makes the encoder work in short steps and tightens the limits to 25 ms p99 and 100 ms max.

Verification

Headline: Prime monitor, 1,000 production-sized episodes (~8 GB of JSON), main against this branch. Main ran this branch's test, with the fake endpoint gzipping at main's level 9.

main This branch
Episodes delivered 725 of 1,000 1,000 of 1,000
Lost to a full upload queue 27 0
Lost when the 60 s drain ran out 248 0
Slowest log() up to 5 s (blocked on the full queue) 0.6 ms
Event-loop lag p99 / max not reached (failed on delivery) 14 / 17 ms
Test time 217 s 28 s

Scale: 10,000 episodes of 2.2 MB (~22 GB), from a local copy of the test with the count raised:

Setup Result
No network time 0 dropped; log() max 1.4 ms; event-loop lag p99 14 ms, max 21 ms; 570 MB peak RSS
100 ms + 100 MB/s per request, 1 request in flight 2,595 delivered within the 60 s drain
Same, 4 in flight 9,822 delivered
Same, 8 in flight (the default) 10,000 delivered; event-loop lag p99 12 ms; 860 MB peak RSS

The upload rate is ~180 episodes/s (~400 MB/s of JSON). Encoding the records is the limit.

Full load-test grid at production sizes, this branch (dev box): 9 passed.

1,000 episodes Event-loop lag p99 / max log() max
prime 14 / 17 ms 0.6 ms
file 47 / 93 ms 177 ms
wandb 0.9 / 0.9 ms 0.6 ms

CI: on the CI runner, the file monitor at 1,000 episodes measured event-loop lag p99 60 ms and max 157 ms, within this PR's limits (100 / 250 ms), and log() up to 299 ms (limit 1 s). With #4366 the same case measures p99 6 ms and max 12 ms.

Other checks:

  • pytest tests/unit/train/sft/test_prime_monitor.py tests/unit/utils/test_links.py tests/unit/orchestrator/test_episode_records.py tests/unit/train/rl -m "not gpu": 29 passed.
  • uvx uv@0.12.0 lock --check passes.

Merge order

  1. feat: non-blocking, concurrent run uploads in prime-runs and prime-traces prime#1136 and feat: upload an episode's own to_json when it names the run prime#1140: merged and released as prime-runs 0.1.6 and prime-traces 0.0.12.
  2. feat: non-blocking, concurrent prime uploads #4363 (this PR): ready to merge. It does not need feat: encode episodes to JSON one node at a time and record runs on traces verifiers#3042.
  3. feat: encode episodes to JSON one node at a time and record runs on traces verifiers#3042
  4. feat: encode episodes for the file and prime monitors one node at a time #4366

🤖 Generated with Claude Code


Note

Medium Risk
Changes the hot path for RL training telemetry (episode/metrics enqueue) and bumps external SDK versions; misbehavior could drop or delay uploads under load, though load tests now enforce delivery and loop responsiveness.

Overview
Prime logging no longer blocks the orchestrator event loop by pinning prime-runs[train]>=0.1.6 (and prime-traces 0.0.12 in the lockfile), which uses a non-blocking upload queue, concurrent uploads, and lighter gzip.

PrimeMonitor now calls run.log_metrics and run.log_episodes directly instead of asyncio.to_thread, matching SDK behavior where enqueue never blocks.

The monitor load test is reworked to use production-like episode sizes (lognormal ~6.4 MB median), shared trace templates for memory, a thread-safe fake Traces API, and multi-chunk file delivery checks. The Prime monitor at 1,000 episodes is no longer expected to fail; responsiveness asserts split event-loop lag (p99 100 ms) from per-log() duration (max 1 s).

Reviewed by Cursor Bugbot for commit 11ae629. Bugbot is set up for automated code reviews on this repo. Configure here.

mikasenghaas and others added 2 commits November 2, 2026 18:39
PrimeIntellect-ai/prime#1136 gzips at level 1, keeps up to eight
upload requests in flight, and bounds the upload queue by records
with a submit that never blocks. prime-runs moves into
override-dependencies next to prime-traces, because verifiers pins
it to an older commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SDK's submit never blocks now, so the prime monitor calls
run.log_metrics and run.log_episodes on the event loop. Each
asyncio.to_thread hop had to win the GIL from the uploader thread
several times, so under load a log() call took up to 87 ms.

The load test drops its expected failure for 1,000 episodes. Its
fake Traces endpoint gzips at the SDK's level and counts lines under
a lock, since the client now sends several requests at once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The load test used one 2.2 MB episode. A production RL run's episodes
are larger and vary a lot: median 6.4 MB, p90 17 MB, p99 35 MB,
uncompressed. Each episode now draws its size from a lognormal through
that median and p90, which also matches the run's mean and p99. Sizes
are capped at 60 MB, under Prime Traces' 64 MiB line limit. The
episodes share 24 traces at log-spaced sizes, so the test's memory
stays small. A thousand episodes is now about 8 GB of JSON, close to
one production step of 1,024 samples.

The file monitor's check counted only the first trace chunk, read
whole. It now streams every chunk, since 8 GB spans two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mikasenghaas and others added 5 commits November 2, 2026 20:45
A log() call may await the monitor's own work: the file monitor awaits
its write on a worker thread, which encodes the episode. At production
sizes that takes up to ~400 ms on CI for a 60 MB episode, while the
event loop keeps serving other tasks. The lag limits cover the loop,
so log() calls get a looser limit of 1 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At production sizes the file monitor encodes each episode in one call,
which stalls the event loop with a p99 of ~60 ms on CI. The limit
covers that until the encoder works in short steps, which lowers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Verifiers main requires prime-runs from PyPI instead of pinning a git
commit, so with the submodule on main the SDK overrides go away. This
also moves prime-sandboxes to 0.5.4, which verifiers main requires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	deps/verifiers
#	pyproject.toml
#	uv.lock
kcoopermiller
kcoopermiller previously approved these changes Nov 3, 2026
@mikasenghaas
mikasenghaas merged commit 7e16629 into main Nov 3, 2026
11 checks passed
@mikasenghaas
mikasenghaas deleted the feat/sdk-upload-perf branch November 3, 2026 00:34
mikasenghaas added a commit to PrimeIntellect-ai/verifiers that referenced this pull request Nov 3, 2026
…races (#3042)

## Summary

- **`Episode.to_json` and `Trace.to_json` encode one node at a time.**
- Pydantic's dump and orjson each hold the GIL for a whole call. Before,
each method made one call over the whole record, so encoding a large
episode stalled every other thread of the process, such as an asyncio
event loop, for as long as it took.
- Each call now covers one node, and the encoder releases the GIL after
each millisecond of encoding (`time.sleep(0)`). Without that release, a
busy thread keeps the GIL until CPython's 5 ms switch interval forces a
handoff, and an event loop waits that long several times per wakeup.
Releasing after every node instead made encoding ~3x slower.
- The output is byte for byte `orjson.dumps(to_record(),
option=OPT_SERIALIZE_NUMPY)`. Each trace and node is dumped as its
declared field type, as the parent's dump does. The parts are joined
once at the end, so the record is copied once.
- **`Trace.run`.** `Trace` gets a `run` field, and
`Episode.record_run(run)` sets it on the episode and on each of its
traces.
- Prime Traces reads the run from each trace (`trace.run.id`) and
derives an episode's run from its members. So `to_record()` and
`to_json()` now carry what the Prime SDK used to stamp, and the SDK can
upload `to_json()` as it is (PrimeIntellect-ai/prime#1140).
- The run types (`PolicySpan`, `TrainWorkInfo`, `EvalWorkInfo`,
`WorkInfo`, `TrainRunInfo`, `EvalRunInfo`, `RunInfo`) move from
`episode.py` to `trace.py`, which `Trace` needs. `verifiers.v1` exports
them as before.
- The delta stream sends `run` with the trace header. Env servers send
`None`; the consumer stamps the run when the episode arrives.

## Verification

- `pytest tests/unit`: 245 passed, 10 skipped (no harbor, no
`PRIME_API_KEY`).
- `to_json` equals `orjson.dumps(to_record())` byte for byte: for a
trace and an episode, with and without float rounding, with nested
`exclude` specs (`__all__` plus a per-trace index), and with a
`TaskData` subclass.
- `record_run` puts the run on the episode and every trace, `to_json`
carries it, and the record validates back to the same run.
- Worst event-loop stall while another thread encodes, and CPU per
episode. The episodes are synthetic agentic episodes at the sizes of a
production RL run:

  | Episode | Before: CPU / worst stall | After: CPU / worst stall |
  |---|---|---|
  | 8.4 MB (production mean) | 20 ms / 15 ms | 21 ms / 2.3 ms |
  | 35 MB (production p99) | 81 ms / 55 ms | 91 ms / 5.2 ms |
  | 133 MB (production max) | 319 ms / 191 ms | 359 ms / 12 ms |

- End-to-end numbers are in PrimeIntellect-ai/prime-rl#4366, which
writes and uploads episodes with this encoder under prime-rl's monitor
load test.

## Merge order

1. ~~PrimeIntellect-ai/prime#1136~~ and
~~PrimeIntellect-ai/prime#1140~~: merged and released as `prime-runs`
0.1.6 and `prime-traces` 0.0.12.
2. **#3042 (this PR)** and PrimeIntellect-ai/prime-rl#4363, in either
order.
3. PrimeIntellect-ai/prime-rl#4366

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Serialization logic is substantially rewritten (though
contract-tested); wire JSON gains optional `trace.run`, and code that
imported run types from `verifiers.v1.episode` must import from `trace`
or `vf` instead.
> 
> **Overview**
> **`Trace.to_json` and `Episode.to_json`** no longer dump the full
record in one pydantic/orjson call. They build JSON in pieces
(`splice_json`, `trace_json_parts`), encoding each message node
separately and yielding the GIL about every millisecond so large
rollouts don’t block asyncio and other threads. Output stays
**byte-identical** to `orjson.dumps(to_record(), OPT_SERIALIZE_NUMPY)`,
including nested `exclude` specs and custom task types.
> 
> **Run metadata moves onto each trace.** `Trace` gains optional `run`,
and **`Episode.record_run`** now stamps the same `RunInfo` on the
episode and every trace in `traces`. The run-related models
(`PolicySpan`, `TrainRunInfo`, `EvalRunInfo`, etc.) live in
**`trace.py`** instead of `episode.py`; **`import verifiers.v1 as vf`**
still exposes them. The live trace delta stream sends **`run` in the
trace header** (often `None` until the consumer stamps it).
> 
> Tests assert `to_json` ↔ `to_record` parity and that stamped runs
round-trip through JSON validation.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
dabe65d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants