Skip to content

fix: count sampled tokens with np.count_nonzero #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faresobeid merged 1 commit into from
Oct 24, 2026
Merged

fix: count sampled tokens with np.count_nonzero #4251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/prime_rl/orchestrator/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from concurrent.futures import ThreadPoolExecutor
from typing import Any

import numpy as np
import verifiers.v1 as vf

from prime_rl.utils.logger import InterceptHandler, get_logger, setup_logger
Expand Down Expand Up @@ -50,7 +51,7 @@ def node_policy_versions(node: vf.MessageNode, fallback: int) -> Iterator[tuple[
``node.token_ids``: the policy step whose weights sampled them, from the
engine's ``weight_versions`` labels. Tokens without a step label (engines
whose updates bypass ``/update_weights``, e.g. Dynamo) get ``fallback``."""
sampled = sum(node.mask)
sampled = int(np.count_nonzero(node.mask))
offset = len(node.mask) - sampled
if not node.weight_versions:
if sampled:
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/orchestrator/test_token_policy_ages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from types import SimpleNamespace

import numpy as np
from verifiers.v1.types import WeightVersionSpan

from prime_rl.orchestrator.utils import token_policy_ages
Expand All @@ -13,8 +14,8 @@ def test_token_policy_ages_counts_labelled_tokens_only():
]
trace = SimpleNamespace(
nodes=[
SimpleNamespace(mask=[False, True], weight_versions=None),
SimpleNamespace(mask=[False] + [True] * 12, weight_versions=spans),
SimpleNamespace(mask=np.array([False, True]), weight_versions=None),
SimpleNamespace(mask=np.array([False] + [True] * 12), weight_versions=spans),
]
)

Expand Down
Loading