Repository navigation
feat(trainer): Nesterov momentum for Muon by default - #4113
Merged
Merged
Conversation
MuonConfig gets nesterov (default True), passed to dion's Muon, whose own default is False.
snimu
marked this pull request as ready for review
October 16, 2026 08:39
samsja
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on Nesterov momentum for Muon by default.
What changes
MuonConfiggetsnesterov: bool = True. It is passed to dion'sMuon, whose own default isFalse.optim.nesterov = falseto get the old behavior.Why
muon_reference) defaults tonesterov=True.The effect on SFT and RL fine-tuning has not been tested.
Validation
configs/debug/fake/sft.toml, Qwen3-0.6B, lr 1e-3, 20 steps, H200): trains without errors,nesterov = truein the resolved config, loss 8.46 at step 1 and 6.61 at step 20 (noisy on the fake data: 4.80 at step 12, 8.37 at step 14).