Repository navigation
fix: release the allocator cache after every checkpoint load #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -389,6 +389,12 @@ def is_online_eval_step(step: int) -> bool: | |
| if world.is_master: | ||
| prune_broadcasts_beyond(config.run_dir, startup_version) | ||
| logger.info(f"Broadcasting startup policy weights (v{startup_version}) for online evals") | ||
| # The per-layer gather peaks well above the resident weights, and on a resume | ||
| # it lands on the pool the checkpoint load just left behind. Release cached | ||
| # blocks first, draining pending work so empty_cache cannot free a block out | ||
| # from under a running kernel. Mirrors the RL trainer's broadcast. | ||
| torch.cuda.synchronize() | ||
| torch.cuda.empty_cache() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mikasenghaas did you test without this addition? Just with the Also don't believe calling |
||
| weight_sender.broadcast(model, startup_version) | ||
|
|
||
| logger.info(f"Starting training loop (max_steps={config.max_steps or 'infinite'})") | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think this is all more closely related to memory fragmentation. Unconditionally doing
clear/collect/empty_cacheis more aggressively dropping references and letting the allocator reset its cache before doing further allocations, which may let the newer allocations be less fragmented and reserve less memory.Do you have the before/after peak allocated memory numbers, too? Would probably be informative.