Repository navigation
chore(configs): drop recipe lines that repeat defaults - #3982
Merged
Merged
Conversation
Remove weight_broadcast.type = nccl, ac.freq = 1, dist_timeout_seconds = 3600, enable_return_routed_experts = true next to enable_router_replay, and stale skip_optimizer = true. Fix the fused_lm_head_token_chunk_size default in docs/scaling.md (8192).
faresobeid
marked this pull request as ready for review
October 10, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop recipe lines that only repeat what the config already resolves to. The resolved configs do not change, except for
skip_optimizer(see below).[weight_broadcast] type = "nccl":rlalready picks NCCL when inference is managed and LoRA is off. Removed from minimax-m2.5 swe, intellect-3.1 rl, and qwen3-30b-a3b swe/math. The block stays in examples/extra/dynamo/rl.toml (no managed inference, so the default there is filesystem) and in glm-5.3 (it also sets port and timeout).ac.freq = 1(the default) is removed from 8 recipes. The[*.model.ac]table header stays, matching the GLM-4.5-Air recipes.trainer.dist_timeout_seconds = 3600/dist_timeout_seconds = 3600(the default) is removed from 5 RL recipes and vlm/sft-moe.inference.vllm.enable_return_routed_experts = trueis removed wheretrainer.enable_router_replay = truealready sets it (glm-4.5-air ×4, nemotron-3-super).[trainer.ckpt] skip_optimizer = trueis removed from glm-4.5-air swe-budget/search/terminal and nemotron-3-super swe.fused_lm_head_token_chunk_sizedefault is 8192 (since Increase chunk size to 8k #3302), not 1024.Not touched
fused_lm_head_token_chunk_size = 1024pins (7 recipes) andattn = "flash_attention_3"pins (10). Should they stay as memory/hardware choices?[ac_offloading] max_inflight_activationslines (a separate PR removes the field).[weight_broadcast]blocks of the GLM-4.5-Air and nemotron recipes (handled in the weight_broadcast.timeout PR, to avoid a conflict).Test plan
pytest tests/unit/orchestrator tests/unit/test_configs.py -m "not gpu": 334 passed (validates every TOML under configs/ and examples/).model_dump):trainer.ckpt.skip_optimizerTrue → False in the 4 recipes above;template_pathalso differs (main checkout vs this worktree), which is not a recipe change.Note
Low Risk
Mostly documentation and deduplication; the only resolved-config change is
skip_optimizerfalse on four recipes that resume with full optimizer state, which matches their intended training flow.Overview
Trims RL/SFT example and advanced recipe TOMLs by deleting settings that already match framework defaults, so recipes only spell out non-default choices.
Removed redundant
[weight_broadcast] type = "nccl",trainer.model.acfreq = 1,dist_timeout_seconds = 3600, andinference.vllm.enable_return_routed_expertswhere NCCL broadcast, AC frequency, dist timeout, and routed-expert return are implied (e.g. managed inference +enable_router_replay). Dropped[trainer.ckpt] skip_optimizer = truefrom four GLM-4.5-Air and Nemotron SWE/search/terminal recipes so resume loads optimizer state from their own checkpoints instead of discarding it.docs/scaling.mdnow documentsfused_lm_head_token_chunk_sizedefault 8192 (was incorrectly 1024). Explicit pins likefused_lm_head_token_chunk_size = 1024in memory-tight recipes are unchanged.Reviewed by Cursor Bugbot for commit c87c43d. Bugbot is set up for automated code reviews on this repo. Configure here.