Repository navigation
fix(launch): node-local vLLM and FlashInfer caches by default - #3981
Merged
Merged
Conversation
faresobeid
marked this pull request as ready for review
October 10, 2026 18:40
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ac13f03. Configure here.
Set VLLM_CACHE_ROOT=/tmp/vllm-cache-<uid> and FLASHINFER_WORKSPACE_BASE=/tmp/flashinfer-<uid> in the default inference env vars and drop the by-hand copies from the GLM-4.5-Air recipes.
faresobeid
force-pushed
the
fix/node-local-vllm-flashinfer-cache
branch
from
October 10, 2026 18:47
ac13f03 to
fe8a34d
Compare
mikasenghaas
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
VLLM_CACHE_ROOT=/tmp/.vllm-cache-<uid>andFLASHINFER_WORKSPACE_BASE=/tmp/.flashinfer-cache-<uid>are added toDEFAULT_INFERENCE_ENV_VARS.TRITON_CACHE_DIRgot the same treatment in fix(launch): default TRITON_CACHE_DIR to a node-local path #3877./tmp/.vllm-cache,/tmp/.flashinfer-cache) are removed from the four GLM-4.5-Air recipes. Those paths were shared by every user on a node.The paths are dot-prefixed so the SLURM start-up cleanup (
rm -rf /dev/shm/vllm-* /dev/shm/vllm_* /tmp/vllm-* /tmp/vllm_* /tmp/torch-* /tmp/torchelastic_*in the multi_node_rl, multi_node_sft and inference sbatch templates) does not wipe them. These are the same names the recipes used before.Precedence is the same as for the other launcher defaults:
[env_vars]or[inference.env_vars]override them; a value exported in the shell does not.Why
~/.cache/vllmand FlashInfer's JIT cache under$HOME, which is usually the shared filesystem./tmpbecause the NFS cache hung inference startup.Overlap
VLLM_CACHE_ROOT/FLASHINFER_WORKSPACE_BASEunder/tmp/garrett/to new DeepSeek-V4 recipes. With this PR those lines can go.Test plan
pytest tests/unit/orchestrator tests/unit/test_configs.py tests/unit/utils -m "not gpu": 365 passed (rebased on origin/main 41a8ed0)..vllm-cache-<uid>,.flashinfer-cache-<uid>and, as a control,vllm-cache-<uid>. Only the control matched.ruff checkandruff format --checkonprocess.py: clean.rl @ examples/advanced/glm-4.5-air/swe.toml --dry-run:rl.sbatchexports both vars only in the inference block (/tmp/.vllm-cache-<uid>,/tmp/.flashinfer-cache-<uid>).--inference.env-vars '{"VLLM_CACHE_ROOT": "/scratch/vc"}', the sbatch exports/scratch/vc.Note
Low Risk
Launcher default env vars for inference only; configs can still override, with no auth or training logic changes.
Overview
Inference launches now default vLLM and FlashInfer compile/JIT caches to per-user paths under
/tmp(VLLM_CACHE_ROOT,FLASHINFER_WORKSPACE_BASE), matching the existing Triton cache behavior and avoiding shared$HOMEor NFS caches that can leave tensor-parallel ranks on mismatched artifacts and hang.The four GLM-4.5-Air example recipes drop redundant
[inference.env_vars]blocks that duplicated those settings. docs/scaling.md documents the launcher defaults and notes overrides via[env_vars]or componentenv_vars.Reviewed by Cursor Bugbot for commit fe8a34d. Bugbot is set up for automated code reviews on this repo. Configure here.