Repository navigation
chore(models)!: remove MiniMax M2 support; drop GLM-4-9B mention - #3868
Closed
faresobeid wants to merge 2 commits into
Closed
faresobeid wants to merge 2 commits into
faresobeid wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes MiniMax M2 (
minimax_m2) support, and drops the dense GLM-4-9B-0414 mention from the model tables. No back-compat shims: a MiniMax M2 checkpoint now fails at trainer setup like any other unsupported architecture.Removed
trainer/models/minimax_m2/,configs/advanced/minimax-m2.5/, and links inconfigs/README.md,examples/README.md,docs/configuration.md.inference/patches.py:monkey_patch_minimax_m2_think_end_passthroughandmonkey_patch_minimax_m2_for_lora.MiniMaxAI/MiniMax-M2tool/reasoning-parser auto-detection (minimax_m2,minimax_m2_append_think), plus its parser test rows. Without the think-end patch, theappend_thinkserving path would silently lose</think>, so both go together.minimax_m2preset inscripts/mini_moe.py; MiniMax case intest_moe_conversions.py.docs/advanced.mdrows.GLM-4-9B-0414
README and
docs/advanced.mdnow listglm4_moeas GLM-4.5 MoE / INTELLECT-3 only. Theglm4_moemini model inscripts/mini_moe.py(and itsdocs/development.mdexample) takes its tokenizer fromzai-org/GLM-4.5-Airinstead ofTHUDM/GLM-4-9B-0414. The preset's pad/eos ids (151329<|endoftext|>, 151336<|user|>, 151338<|observation|>) are the same in that tokenizer, and its 151365 tokens fit the preset'svocab_size=151552.Checks
ruff check .andruff format --check .: clean.pytest -m "not gpu" tests/unit/orchestrator tests/unit/test_configs.py tests/unit/test_parsers.py tests/unit/train tests/unit/inference: all pass excepttest_cpu_adam.py::test_native_cpu_adamw_matches_fused_torch_and_preserves_gradients, which fails the same way onmainon this CPU box.seq_lens, SDPA stand-in for the flash kernel). Logits, all parameter grads and state-dict keys are bitwise identical tomain. DeepSeek-V4 needs GPU kernels, so it was not run.docs/algorithms.md, which describes the externalrendererspackage).Conflicts with open PRs
minimax_m2/*andscripts/mini_moe.py. Drop the minimax hunks.minimax_m2/modeling_minimax_m2.py. Drop the hunk.inference/patches.py. Only the call list inapply_shared_vllm_patchesshould conflict.