Repository navigation
refactor(orchestrator): fold packing.py into batch.py - #3842
Merged
Merged
Conversation
faresobeid
force-pushed
the
refactor/fold-packing
branch
from
October 4, 2026 23:25
48c0821 to
986f5bf
Compare
samsja
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
BatchPacker(35 lines) fromorchestrator/packing.pyintoorchestrator/batch.pyand deletespacking.py. The class only wrapsbuild_bin_costandprepare_batch, which already live inbatch.py.Item 6 of the orchestrator review.
Behavior change: none (pure move; the import in
orchestrator.pyis updated).Checks
pytest tests/unit/orchestrator tests/unit/test_configs* -m "not gpu": 291 passedruff check,ruff format --check: cleanpython -c "import prime_rl.orchestrator.orchestrator"OKgit diffshows only the move and the import lines).GPU checks: none needed.
Conflicts
batch.pyimports only.ShipperimportsBatchPackerfrompacking, which becomes a one-line change tofrom prime_rl.orchestrator.batch import BatchPacker.batch.py.Note
Low Risk
Pure file move and import path update with no logic changes to training batch packing.
Overview
Colocates batch packing with the bin-packing helpers it already delegates to.
BatchPackermoves fromorchestrator/packing.pyintoorchestrator/batch.pynext tobuild_bin_costandprepare_batch;packing.pyis removed. The orchestrator now importsBatchPackerfrombatchinstead ofpacking. Class behavior andpack()semantics are unchanged.Reviewed by Cursor Bugbot for commit 986f5bf. Bugbot is set up for automated code reviews on this repo. Configure here.