Repository navigation
feat(rl): add LoRA and replay support with inference/trainer startup fixes - #3735
Draft
biswapanda wants to merge 3 commits into
Draft
biswapanda wants to merge 3 commits into
biswapanda wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These are shared RL interfaces and validation rules, not backend-specific discovery or worker-management behavior. Evaluation needs an explicit request-construction mode; filesystem weight updates need a backend-neutral way to report the active adapter model; replay requires complete branch metadata before training; and explicitly trusted custom VLM checkpoints must pass configuration validation.
Aggregated workers should not inspect removed NIXL-only configuration fields when no NIXL connector is active. Text-only composite-model training should not require an image adapter at startup; image-bearing batches still resolve and validate the adapter before materialization.
Validation
Integration order
This PR extracts backend-independent support from #3629. Both target upstream main; merge this prerequisite first, then #3629.