Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #3429 (
feat/qwen3-5-native). Remove HF reference-model test scaffolding and organize retained model tests by family so native behavioral coverage can be expanded consistently.Created and tracked with
gh stack. The PR is based directly on Qwen3.5. GitHub stack-group linking is separate: the existing group already contains #3419, #3429, and #3434, and the CLI only permits appending above #3434. Its base was not substituted for Qwen3.5, and the existing PR bases were left unchanged.Exactly two commits:
tests/unit/train/models/<model_name>/, splitting the generic Qwen3/GLM4/Llama file into those families. Keep shared fusion, checkpointing, MoE, and multi-family conversion tests shared. Qwen3.5 already has the target layout.No production changes. DeepSeek V4 and its associated kernel tests are unchanged. Existing non-HF test limitations, including skipped checks and weak replay assertions, are retained for the coverage follow-up. Model families whose only tests were deleted do not get empty test files.
Proposed native coverage
This is the proposed follow-up, not coverage implemented by this cleanup. Use small local architecture configs and public Prime model construction with the normal attention resolver. No HF forward reference models, copied HF initialization, or per-model FlashAttention backend matrices.
The common model suite should cover:
Shared follow-up work:
pytest -m gpuskips the current distributed model checks.Transformers remains a production dependency of the current Prime factory/base/configs. This PR removes HF model-reference testing; it does not claim to remove that dependency.
Validation
Stack created with GitHub Stacks CLI • Give Feedback 💬