Conversation
samsja
force-pushed
the
feat/dynamo-admin-plane
branch
from
September 3, 2026 00:07
a8b4377 to
3b2dd8a
Compare
samsja
force-pushed
the
feat/dynamo-admin-plane
branch
from
September 3, 2026 03:17
3b2dd8a to
c6988fc
Compare
samsja
commented
Sep 3, 2026
Comment on lines
+192
to
+197
| def setup_admin_client(client_config: ClientConfig, model_name: str) -> AdminClient: | ||
| if client_config.dynamo is not None: | ||
| from prime_rl.inference.dynamo import DynamoAdminClient | ||
|
|
||
| return DynamoAdminClient(client_config, model_name) | ||
| return AdminClient(client_config) |
Member
Author
There was a problem hiding this comment.
can we do if else here I dont like like this
samsja
force-pushed
the
feat/dynamo-admin-plane
branch
from
September 3, 2026 03:28
c6988fc to
874b3ae
Compare
samsja
force-pushed
the
feat/dynamo-admin-plane
branch
from
September 3, 2026 20:39
874b3ae to
6cb46cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamoAdminPlaneas a specialization of the staticAdminPlaneintroduced by chore(inference): introduce admin plane abstraction #3472This is a stacked follow-up to #3472 and incorporates the Dynamo behavior from #3469.
InferenceClientremains responsible for data-plane requests; generic weight receivers call one typedAdminPlane.update_weightsoperation and contain no Dynamo flags or worker metadata.Validation
uv run ruff check packages/prime-rl-configs/src/prime_rl/configs/rl.py packages/prime-rl-configs/src/prime_rl/configs/shared.py src/prime_rl/evals/evals.py src/prime_rl/inference/dynamo.py src/prime_rl/orchestrator/clients.py src/prime_rl/orchestrator/orchestrator.py tests/unit/inference/test_dynamo.py tests/unit/test_configs.pyuv run python -m compileall -q src/prime_rl/inference/dynamo.py src/prime_rl/orchestrator/clients.py src/prime_rl/orchestrator/orchestrator.py src/prime_rl/evals/evals.pyThe complete
tests/unit/test_configs.pysuite additionally requires taskset plugins that are not installed in this worktree (scaleswe,reverse-text, and others).