Repository navigation
fix(evals): show error rate on partially evaluated epochs - #3462
Merged
Merged
Conversation
samsja
force-pushed
the
feat/evals-log-error-rate
branch
from
September 1, 2026 21:42
538a455 to
eb91658
Compare
samsja
marked this pull request as ready for review
September 2, 2026 03:30
The cancelled-epoch warning line reported Reward with no signal of how many of the completed episodes errored. Show the same Error rate as the completed-epoch success line.
samsja
force-pushed
the
feat/evals-log-error-rate
branch
from
September 2, 2026 20:09
eb91658 to
010a7ec
Compare
hallerite
approved these changes
Sep 2, 2026
mikasenghaas
added a commit
that referenced
this pull request
Sep 14, 2026
Main moved the prime monitor onto prime-runs (#3459) and renamed the admin clients to AdminPlane (#3472). The eval monitor now opens one prime-runs eval run per finished epoch instead of posting to /evaluations by hand, which retires prime_rl.monitors.platform: the SDK's projection and metrics modules own the sample format and the run aggregates. The eval runner takes the AdminPlane rename and the error-rate line from #3462. The swe example stays under examples/eval (main had moved it to configs/evals for `uv run evals`), and the verifiers submodule follows feat/remove-eval-cli's merge of main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv run evalsentrypoint log now shows theErrorrate next toReward— previously it reported reward with no signal of how many completed episodes erroredThe completed-epoch success line already shows
Errorand is unchanged:Verification
uv run ruff check src/prime_rl/evals/evals.py— passeduv run ruff format --check src/prime_rl/evals/evals.py— passedNote
Low Risk
Logging-only change in eval finalization; no behavior, scheduling, or metric emission changes.
Overview
When an eval epoch is cancelled (e.g. superseded by a newer checkpoint), the warning log line now includes the Error rate from completed episodes, using the same
full.has_errorformatting as the full Evaluated success line.Previously that partial-eval message only showed reward and completion/cancel counts, so operators could not see how many finished rollouts failed without digging into metrics.
Reviewed by Cursor Bugbot for commit 010a7ec. Bugbot is set up for automated code reviews on this repo. Configure here.