feat: per-source env-server address via serve.address - #3218
Merged
Conversation
Setting serve.address on a train/eval source marks its env server externally managed: the launcher neither writes its TOML nor spawns a server for it, and the orchestrator connects to the given address. Unset sources keep the derived loopback address, with indices still positional across all sources. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Companion verifiers bump makes ServeConfig.address optional with no default, so the per-source serve block needs no prime-rl subclass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mikasenghaas
marked this pull request as ready for review
August 8, 2026 18:14
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72a28e3. Configure here.
samsja
approved these changes
Aug 8, 2026
eexwhyzee
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
[serve]block is now verifiers'ServeConfig, consumed as-is — no prime-rl mirror or subclass. feat: make ServeConfig.address optional with no default verifiers#2301 (merged) makesServeConfig.addressoptional with no default (str | None = None); this PR bumpsdeps/verifiersto that rev (29e3a0f7a, current verifiers main).address(default) keeps today's behavior: the launcher serves the source at the derivedtcp://127.0.0.1:<env_server_base_port + index>address.serve.addressper source.uv run env-serverwithout an address keeps bindingtcp://127.0.0.1:5000(serve_envfalls back to its default loopback bind onNone).Supersedes #3216: the same capability expressed on the source itself instead of a launcher-owned top-level map — no
<split>/<resolved_name>string keys, and no key-typo validator needed since the field lives on the source it applies to.Verification
Sanity-checked with the main venv against this branch and the new verifiers rev: a 3-source config (
train/a,train/bwithserve.address = "tcp://env-b.svc:5000",eval/c) yieldsenv_addressesof{a: tcp://127.0.0.1:5000, b: tcp://env-b.svc:5000, c: tcp://127.0.0.1:5002},env_servers()skipsb, and the serialized orchestrator TOML round-trips the address while unset addresses don't serialize.🤖 Generated with Claude Code