fix: token_id-formatted logprob tokens in the qwen3-vl fake engine - #3161
Draft
mikasenghaas wants to merge 1 commit into
Draft
fix: token_id-formatted logprob tokens in the qwen3-vl fake engine#3161mikasenghaas wants to merge 1 commit into
mikasenghaas wants to merge 1 commit into
Conversation
renderers 0.1.9.dev9 rejects sampled-token evidence whose logprob token is not 'token_id:<id>' (renderers#108); the fake engine response predates the format. CI never sees this test (it skips without the cached HF snapshot). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_FakeOpenAIengine response intest_qwen3_vl_e2e.pyemitstoken: "t1"-style logprob entries; renderers 0.1.9.dev9 (fix(client): reject malformed sampled-token evidence renderers#108, pulled in by chore: bump renderers to 0.1.9.dev9 #3158) rejects sampled-token evidence whose logprob token is nottoken_id:<id>, so the test fails onmain.Verification
MalformedGenerateResponseError: Engine response choice.logprobs.content[0].token must be 'token_id:50'.1 passed.🤖 Generated with Claude Code