Skip to content

chore: dependency updates (flash-attn-3, wheels, lockfile) - #2234

Merged
samsja merged 1 commit into
mainfrom
sami/update-deps
Apr 9, 2026
Merged

chore: dependency updates (flash-attn-3, wheels, lockfile)#2234
samsja merged 1 commit into
mainfrom
sami/update-deps

Conversation

@samsja

@samsja samsja commented Apr 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Install flash_attn_3 via PyPI resolution from the PyTorch test/cu128 index (explicit pytorch-cu128-test index + [tool.uv.sources]) instead of pinning a single GitHub wheel.
  • Move deep-ep, deep-gemm, and nixl-cu12 direct URLs to the research-pre-built-wheels release.
  • Bump the vLLM router wheel to 0.1.16 (manylinux 2.28 tarball).
  • Refresh uv.lock.

Made with Cursor


Note

Medium Risk
Moderate risk because it changes how GPU-critical dependencies are sourced (including using the PyTorch test index), which can impact build/install reliability and runtime compatibility.

Overview
Switches the flash-attn-3 extra from a pinned GitHub wheel to resolving flash_attn_3 via a newly added explicit pytorch-cu128-test index, and updates uv.lock accordingly (including aarch64 support entries).

Moves deep-ep, deep-gemm, and nixl-cu12 wheel URLs to the research-pre-built-wheels release, and bumps vllm-router to the 0.1.16 manylinux 2.28 wheel. The lockfile is refreshed, including updated Torch wheel download host URLs.

Reviewed by Cursor Bugbot for commit 13dbcf0. Bugbot is set up for automated code reviews on this repo. Configure here.

@samsja
samsja marked this pull request as ready for review April 9, 2026 07:09

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 13dbcf0. Configure here.

Comment thread pyproject.toml
flash-attn-4 = { git = "https://github.com/Dao-AILab/flash-attention.git", subdirectory = "flash_attn/cute", rev = "abd9943b" }
pydantic-config = { git = "https://github.com/samsja/pydantic_config.git", branch = "main" }
vllm-router = { url = "https://github.com/PrimeIntellect-ai/router/releases/download/v0.1.14/vllm_router-0.1.14-cp38-abi3-linux_x86_64.whl" }
vllm-router = { url = "https://github.com/PrimeIntellect-ai/router/releases/download/v0.1.18/vllm_router-0.1.16-cp38-abi3-manylinux_2_28_x86_64.whl" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vllm-router release tag/wheel version mismatch

Medium Severity

The vllm-router URL references GitHub release tag v0.1.18 but the wheel filename embeds version 0.1.16. The previous entry had these in sync (v0.1.14 / 0.1.14). This mismatch suggests either the wrong release tag or the wrong wheel version was specified, which could mean the project is pinned to an older wheel than intended.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 13dbcf0. Configure here.

@samsja
samsja merged commit faa0b56 into main Apr 9, 2026
12 checks passed
@mikasenghaas
mikasenghaas deleted the sami/update-deps branch August 5, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants