Repository navigation
chore: refactor env groups + a bunch of deprecations #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 60 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
5a2da30
ckpt
mikasenghaas 9761e0b
Merge branch 'main' into chore/env-group-refactor
mikasenghaas 3eef697
chore: flatten env group config and move env_ratios to per-env ratio …
mikasenghaas 1956976
chore: simplify orchestrator env setup and auto-detect group scoring
mikasenghaas ffd7325
chore: introduce Env wrapper class and simplify orchestrator plumbing
mikasenghaas 5c2decc
chore: store sampling_args on Env, remove temp scheduling from orch
mikasenghaas 18b8336
chore: type-narrow TrainEnv constructor to TrainEnvConfig
mikasenghaas 776321d
chore: set sampling args at env init, compute once per orchestrator
mikasenghaas 578b9c6
chore: inline vf_utils into Env, rename get_sampling_args
mikasenghaas f45ae9c
chore: set sampling_args from orchestrator, rename to run_rollout/run…
mikasenghaas c6d34f9
chore: remove dead code, inline spawn/connect into Env
mikasenghaas 40e444a
chore: revert math_group config changes
mikasenghaas 53508bd
chore: remove commented-out TrainEnvConfig stub
mikasenghaas 36f15d1
chore: inline evaluate/generate/run_group into EvalEnv
mikasenghaas 0df5d3e
chore: inline eval pipeline into EvalEnv, remove semaphore and dead code
mikasenghaas 5130f5c
chore: resolve num_workers in configs, cleanup naming and logging
mikasenghaas 051517f
chore: make Envs generic over env type for correct type narrowing
mikasenghaas c844d34
chore: fix tests — remove val config from all TOML files, fix task->e…
mikasenghaas c4ab1f3
chore: unify rollout dispatch with Env.run() helper
mikasenghaas c4b0c32
chore: rename EnvBuffer -> Buffer, BufferSet -> Buffers, narrow to Tr…
mikasenghaas 2b79f91
chore: Buffer takes TrainEnv directly, gets its own dataset
mikasenghaas ce8509b
chore: merge Buffer naming — Buffer is the public API, _EnvBuffer is …
mikasenghaas 7315036
chore: stop hijacking vf task field for env identification
mikasenghaas 021bbde
fix: restore eval interval gate, verification.enabled flag, and minor…
mikasenghaas ce74ea9
Merge remote-tracking branch 'origin/main' into chore/env-group-refactor
mikasenghaas 1db0424
chore: add changelog entries for env group refactor breaking changes
mikasenghaas 7bf7876
chore: improve EnvConfig and EvalEnvConfig field descriptions
mikasenghaas 20af2df
chore: silence noisy eval num_workers warning in config validator
mikasenghaas 35f1b43
chore: remove dead parse helpers, fix ratio field description
mikasenghaas 731fc07
chore: remove env-var modules, inline os.environ into World
mikasenghaas f735482
chore: remove temp scheduler, avoid list alloc in buffer sampling
mikasenghaas ec603e7
chore: merge spawn+connect into Env.start(), add requires_env_server_…
mikasenghaas d98832b
chore: split run into run_rollout/run_group, fix eval group scoring
mikasenghaas bf19583
chore: simplify evaluate() dispatch into single run_with_progress
mikasenghaas 395a376
chore: define run_with_progress per branch to avoid misleading param
mikasenghaas fadb7d1
chore: move get_dataset to TrainEnv, inline get_eval_dataset in evaluate
mikasenghaas cf8e771
chore: load eval dataset once in EvalEnv constructor
mikasenghaas f1fe16a
chore: remove redundant total_count variable in evaluate
mikasenghaas edf343a
mini
mikasenghaas fe7e35e
update config
mikasenghaas c3163c5
chore: remove score_rollouts from EnvConfig, fix group scoring resche…
mikasenghaas a70d485
chore: remove VerificationConfig, rollout scoring is always enabled
mikasenghaas c949c11
fix: wrap single run_rollout result in list in scheduler
mikasenghaas 0ed00b9
chore: rename n/k to descriptive names in evaluate, fix k shadowing
mikasenghaas 9f19477
chore: remove unused num_rollouts param from update_pools
mikasenghaas 7f595cb
chore: rename InflightRolloutInfo to InflightRequest dataclass
mikasenghaas 469ef6c
fix: count rollouts not tasks for group-scoring capacity and metrics
mikasenghaas 6b01f9d
chore: document skip_first removal in changelog
mikasenghaas b0199e1
chore: rename envs to train_envs in Scheduler, move RolloutInput into…
mikasenghaas bea1b11
fix: update Scheduler kwarg from envs to train_envs in orchestrator
mikasenghaas d500b21
Merge branch 'main' into chore/env-group-refactor
mikasenghaas c9a5bcf
Merge branch 'main' into chore/env-group-refactor
mikasenghaas 92a25d6
chore: use composition for TrainConfig/EvalConfig, add per-env sampling
mikasenghaas b7cb3f2
chore: restore group-level num_examples/rollouts_per_example on EvalC…
mikasenghaas f387e81
chore: terminate env servers in parallel during shutdown
mikasenghaas 27e24e3
Merge branch 'main' into chore/env-group-refactor
mikasenghaas 9e24ff4
Merge branch 'main' into chore/env-group-refactor
mikasenghaas f40b261
fix: move usage_reporter.close() outside _graceful_shutdown
mikasenghaas e0fc3a5
better logs
mikasenghaas 8950733
test config
mikasenghaas 297e8ec
chore: move sampling args resolution to config classes
mikasenghaas 092f209
chore: remove unused EvalSaveHFConfig
mikasenghaas d78207c
minor
mikasenghaas 0b9c497
docs: update CHANGELOG with recent config changes
mikasenghaas 40c80a9
chore: restore top_k and min_p fields on EvalSamplingConfig
mikasenghaas c860806
fix: copy group sampling config when resolving per-env defaults
mikasenghaas 3f86940
fix: use orchestrator.train.env in SLURM entrypoint
mikasenghaas 59cbef9
Merge branch 'main' into chore/env-group-refactor
mikasenghaas 09eacfd
fix: only send non-default eval sampling args to inference server
mikasenghaas a49e281
fix: revert EvalSamplingConfig to nullable fields
mikasenghaas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.