Feat: add weigh transfer fix - #2099
Merged
Merged
Conversation
samsja
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Patches vLLM DP engine core request handling and wave coordination logic, which is concurrency-sensitive and could impact distributed inference behavior if assumptions differ across vLLM versions.
Overview
Adds a new vLLM monkeypatch to prevent a pause/resume deadlock in DP mode by changing
EngineCore.add_requestbehavior: it now only emitsstart_wavenotifications when the scheduler is unpaused and forcesengines_running=Truebefore notifying.The new patch is wired into the existing
transformers_v5_compat()general plugin so it runs automatically in all vLLM processes.Written by Cursor Bugbot for commit 1c192cc. This will update automatically on new commits. Configure here.