Skip to content

Feat: add weigh transfer fix - #2099

Merged
S1ro1 merged 2 commits into
mainfrom
fix-weight-transfer-deadlock
Mar 25, 2026
Merged

Feat: add weigh transfer fix#2099
S1ro1 merged 2 commits into
mainfrom
fix-weight-transfer-deadlock

Conversation

@S1ro1

@S1ro1 S1ro1 commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Patches vLLM DP engine core request handling and wave coordination logic, which is concurrency-sensitive and could impact distributed inference behavior if assumptions differ across vLLM versions.

Overview
Adds a new vLLM monkeypatch to prevent a pause/resume deadlock in DP mode by changing EngineCore.add_request behavior: it now only emits start_wave notifications when the scheduler is unpaused and forces engines_running=True before notifying.

The new patch is wired into the existing transformers_v5_compat() general plugin so it runs automatically in all vLLM processes.

Written by Cursor Bugbot for commit 1c192cc. This will update automatically on new commits. Configure here.

@S1ro1
S1ro1 merged commit b92c212 into main Mar 25, 2026
9 checks passed
@mikasenghaas
mikasenghaas deleted the fix-weight-transfer-deadlock branch August 5, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants