Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| 'extra_body fields to hardcode/override on generation requests (e.g. {"return_token_ids": true}).' | ||
| ), | ||
| ), | ||
| ] = {} |
There was a problem hiding this comment.
Missing CHANGELOG entry for new config fields
Low Severity
This PR adds three new config fields to ClientConfig in src/prime_rl/utils/config.py — client_type, sampling_overrides, and extra_body_overrides — but the diff does not include a corresponding CHANGELOG.md update. Per project rules, any PR that modifies configuration structures (including added fields) in src/prime_rl/utils/config.py must update the changelog.
Triggered by project rule: BugBot Instructions
cursor Bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
…_overrides (#1846) Co-authored-by: will brown <willccbb@users.noreply.github.com>
willccbb
marked this pull request as draft
February 21, 2026 06:29
Member
|
done in #1847 |
mikasenghaas
added a commit
that referenced
this pull request
Jun 23, 2026
…etup) 51701f4c (#1846). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting verifiers client type + overriding sampling / extra_body args to support multiple interleaving strategies.
Note
Medium Risk
Moderate risk because it changes how all generation requests are constructed and routed (client type + request parameter overrides), which could alter rollout/eval behavior if misconfigured.
Overview
Adds a configurable
ClientConfig.client_type(instead of a hardcoded verifiers client type) and propagates it through both static and elastic inference pool client creation.Introduces
ClientConfig.sampling_overridesandClientConfig.extra_body_overrides, applies them to both training and eval sampling arg construction viaapply_client_sampling_overrides, while still forcing token-level outputs (logprobs+return_token_ids) required for rollout-to-training conversion. Includes unit tests covering override behavior andclient_typewiring.Written by Cursor Bugbot for commit fe5c90d. This will update automatically on new commits. Configure here.