Conversation
Run the portable ps start-time query under a fixed timezone and locale so a system timezone change does not invalidate daemon ownership metadata.\n\nFixes #879
|
Hi, thanks for taking the time to contribute to Prime Agent! Since open sourcing the project, we’ve received far more pull requests than we can responsibly review and validate. Prime Agent runs directly on users’ machines, so we need to be deliberate about which changes we accept and how they are reviewed. Rather than leave a large backlog that we cannot meaningfully work through, we’re closing the current PR queue and moving to a discussion-first contribution process. We have established new contribution guidelines to help us continue iterating on Prime Agent and better manage contributions from the community. Going forward, we won’t review unsolicited pull requests. Instead, please start with a GitHub Discussion. We’ll identify recurring bugs and feature requests, create Issues for work we want to pursue, and invite pull requests from maintainers or vouched contributors when implementation is ready. Please read the full process documented in our contribution guidelines. While we’re closing this backlog, we’re still reviewing it at a high level to identify recurring bugs, useful ideas, and important problems that we should address ourselves. Thanks again for the time you put into this! |
Summary
ps -o lstart=process identity query withTZ=UTCandLC_ALL=CVerification
npx tsx ../../node_modules/vitest/dist/cli.js --run test/daemon-ps.test.ts(24 tests passed)npm run checkprocess.env.TZbetweenAmerica/Los_AngelesandAsia/Kolkata; both IDs were identicalFixes #879
Note
Fix macOS process identity invalidation caused by timezone changes
getProcessStartIdin session-lease.ts usespsto derive a stable process start identifier, but the output varies with system timezone or locale, causing the running daemon's identity to change.pscall into a newgetPsProcessStartIdhelper that forcesTZ=UTCandLC_ALL=Cin the subprocess environment, ensuring a consistent output regardless of system settings.runProcessQueryto accept an optionalenvoverride so callers can supply a custom environment without affecting the default behavior.Macroscope summarized 7053d4f.