Skip to content

fix(coding-agent): trust supervisor-approved session renames in worker mode - #1702

Closed
snimu wants to merge 6 commits into
snimu/remove-rpc-blanket-timeoutsfrom
snimu/supervised-rename-authority
Closed

snimu wants to merge 6 commits into
snimu/remove-rpc-blanket-timeoutsfrom
snimu/supervised-rename-authority

Merge branch 'snimu/remove-rpc-blanket-timeouts' into snimu/supervise…

1cb0f22
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check completed Aug 27, 2026 in 5m 39s

1 issue identified (21 code objects reviewed).

• Merge Base: bc0fa76
• Head: 1cb0f22

Details

✅ File Path U3 Bytes Comments Posted Reason
➖ packages/coding-agent/test/rpc-client-timeout.test.ts 3636 Excluded by default ignore patterns
✅ packages/coding-agent/.changes/remote-message-single-send.md 233 0
✅ packages/coding-agent/.changes/remove-rpc-blanket-timeouts.md 96 0
✅ packages/coding-agent/.changes/supervised-rename-authority.md 93 0
➖ packages/coding-agent/test/fixtures/rpc-client-hanging-fixture.mjs 25 Excluded by default ignore patterns
➖ packages/coding-agent/test/daemon-mode.test.ts 4467 Excluded by default ignore patterns
✅ packages/coding-agent/src/modes/daemon/daemon-mode.ts 4040 0
❌ packages/coding-agent/src/modes/rpc/rpc-client.ts 9702 1

Billed Total: 13.53KB of diff | $0.68
Saved $0.03 vs. the upper-bound estimate of $0.71 — cached code objects from prior reviews on this PR were not re-billed.

Filtered Issues Details

packages/coding-agent/src/modes/daemon/daemon-mode.ts
  • line 4005: rename_saved_session validates command.sessionPath in the supervisor but, for an active session, forwards the rename to the worker selected by activeSessionId. A client can supply the path of a different session, so the supervisor checks the wrong family/name scope; this new worker-mode path then skips local validation and renames the active session to a duplicate sibling name. Require the supplied path to match the routed active session or validate using that session's actual file. [ Failed validation ]