Repository navigation
Async bash() tool for the kernel runtime #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
1414142
feat(coding-agent): add async-by-default bash() to the kernel runtime
snimu d4fc6ab
chore(coding-agent): tighten bash() comments and changelog fragment
snimu 8a04223
Merge remote-tracking branch 'origin/main' into repl/01-bash-tool
snimu b00a176
fix(coding-agent): address bash() review findings — exact tail retent…
snimu dcc7328
fix(coding-agent): tree-kill bash() process trees on Windows and make…
snimu 07ace49
fix(coding-agent): carry bash() status pipe as stdin so strict-POSIX …
snimu 2f9b740
fix(coding-agent): close status fds when wake-pipe creation fails and…
snimu 938e68c
Merge remote-tracking branch 'origin/main' into repl/01-bash-tool
snimu f4b4196
fix(coding-agent): kill full process trees in the Windows orphan reap…
snimu be2f706
fix(coding-agent): kill one-shot await bash() on cancel, resolve Wind…
snimu 4d57859
fix(coding-agent): confirm group exit before a cancelled one-shot bas…
snimu 161474b
fix(coding-agent): shield the cancelled-await bash() confirm-exit fro…
snimu b83e09b
fix(coding-agent): flag the pump's read-to-commit window so the bash(…
snimu b8c9368
Merge remote-tracking branch 'origin/main' into repl/01-bash-tool
snimu 69c8b4a
fix(coding-agent): resolve taskkill via absolute System32 path in the…
snimu b244459
Merge remote-tracking branch 'origin/main' into repl/01-bash-tool
snimu 1dda76b
fix(coding-agent): write the inactive orphan-journal record only afte…
snimu 60a0ca3
fix(coding-agent): count an already-exited leader as delivered in the…
snimu e2ffa3a
fix(coding-agent): resolve trusted absolute shell host-side and close…
snimu fb61ffc
fix(coding-agent): best-effort-kill pid-only orphan records in daemon…
snimu 486d2e4
fix(coding-agent): resolve the kernel bash shell only from trusted ab…
snimu 2c6f451
fix(coding-agent): contain Windows bash children with kill-on-close j…
snimu 2ca2e03
fix(coding-agent): fall back to taskkill when job termination fails
snimu a0f185e
fix(coding-agent): start Windows bash children suspended and fail clo…
snimu 933f12b
Merge remote-tracking branch 'origin/main' into repl/01-bash-tool
snimu 8d9e4b7
fix(coding-agent): kill the whole tree for enriched orphan records on…
snimu 22f878d
fix(coding-agent): skip the liveness check when the orphan identity i…
snimu 01cd753
fix(coding-agent): journal Windows bash() children before job assignm…
snimu ec78cd7
fix(coding-agent): pre-create the Windows bash() job before spawn and…
snimu 7d0fe21
fix(coding-agent): create Windows bash() children atomically inside t…
snimu 4e68837
chore(coding-agent): compress the atomic-job-association comments to …
snimu e31c652
fix(coding-agent): retain the Windows bash() process handle through j…
snimu 242b34c
fix(coding-agent): serialize Windows bash() abort cleanup under the k…
snimu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| - Added an async-by-default `bash()` callable to the kernel runtime: it returns a live handle immediately (pid/tail/poll/kill/await), bounds in-memory output, and enrolls children in the orphan-process journal so kernel teardown reaps them. | ||
| - Fixed bash() orphan-journal writes marking a child inactive even when the kill signal was not delivered; the record now stays active on delivery failure so the host reaper still owns the process (on Windows a shell that already exited counts as delivered, so clean exits still retire their record). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.