Conversation
Fixes ENG-5147
sethkarten
self-requested a review
August 11, 2026 17:11
sethkarten
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run checkLinear: ENG-5147
Note
Low Risk
Localized interactive prompt keybinding change with no auth, data, or API impact; behavior is covered by regression tests referenced in the PR.
Overview
Down Arrow in the chat prompt no longer jumps to the Agents View entry (subagent summary below the prompt) until the cursor is at the end of the prompt text on the last line.
CustomEditornow gatesonMoveBelowPrompton a newisCursorAtEnd()check instead of only being on the last visual (wrapped) line. The first Down press still moves within the editor (e.g. to line end); focus moves below only when the cursor is already at the true end. Empty prompts behave as before: Down can focus below immediately.The unused
isCursorOnLastVisualLine()bridge on the baseEditorinpi-tuiwas removed.Reviewed by Cursor Bugbot for commit 55ae068. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix Down Arrow in
CustomEditorto stay in nonempty prompts until cursor reaches endPreviously, pressing Down Arrow on any wrapped last visual line would immediately move focus to the Agents View. Now,
CustomEditor.handleInputonly callsonMoveBelowPrompt()when the cursor is at the end of the last line, using a newisCursorAtEnd()helper. The oldisCursorOnLastVisualLine()method onEditoris removed.Macroscope summarized 55ae068.