Fix: Adding new image slide in "Image slider" module (ps_imageslider) does not work #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is also necessary to check the case of creating a new slide (addSlide)
SharakPL
approved these changes
Mar 21, 2024
AureRita
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Hi @Codencode
Thank you for your PR, I tested it and it seems to works as you can see :
recording.158.webm
Tested on 8.1.x and develop :
Because the PR seems to works as expected, It's QA ✔️
Thank you
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also necessary to check the case of creating a new slide (addSlide)
This problem occurs up to version 1.7.6.9 of Prestashop, in subsequent versions it does not occur, however the javascript error which is the cause of the problem is still there.