Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 3.1.2 #82

Merged
merged 21 commits into from
Mar 15, 2023
Merged

Release version 3.1.2 #82

merged 21 commits into from
Mar 15, 2023

Conversation

SharakPL
Copy link
Contributor

Questions Answers
Description? Release 3.1.2
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Release Test

@Hlavtox Hlavtox added this to the 3.1.2 milestone Mar 14, 2023
@AureRita AureRita self-assigned this Mar 15, 2023
@AureRita
Copy link

Hi @SharakPL

Thank you for your PR, I tested it and that what I have :

On 8.0.0 :

The good part :

The RTL changes seems to be here :
image

These relative links seems to works :

http://prestashop.com/en/download
https://prestashop.com/en/download
//prestashop.com/en/download
prestashop.com/en/download
#footer


Issue find :

The bump of the version seems not to works ( even in the file config ) :
image
image

The empty url doesn't seems to works as you can see :
image

The relative links doesn't seems to works with these links :

/content/4-about-us
content/4-about-us
index.php
search?controller=search&s=mug

as you can see :

Untitled_.Mar.15.2023.11_48.AM.webm

On 1.7.8.8 :

All seems to works :

  • the bump of the version is correct,
  • the empty url works
  • all the relative links works

except :

The template RTL seems to load indefinitely as you can see :
Untitled_ Mar 15, 2023 2_45 PM.webm

@AureRita
Copy link

Hi @SharakPL

After a new tests, there is no issue on it, I tried on 8.0.1 when the apidistibutor is disabled and it works and i test it again on 1.7.8.8 and I haven't issue.

So it's QA Approved ✔️

@AureRita AureRita removed their assignment Mar 15, 2023
@SharakPL
Copy link
Contributor Author

Thanks @AureRita 🎉

@SharakPL SharakPL merged commit c5980fe into master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.