-
Notifications
You must be signed in to change notification settings - Fork 57
Add RTL version of sample images #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mparvazi
commented
Feb 22, 2022
•
edited
Loading
edited
Questions | Answers |
---|---|
Description? | Add RTL version of sample images and improve image upload. |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/PrestaShop#27423 & PrestaShop/PrestaShop#27777 |
How to test? | - |
Redo for #67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedbacks :)
Co-authored-by: Progi1984 <[email protected]>
Co-authored-by: Progi1984 <[email protected]>
I changed the condition for upload image, so user can upload image just for one language without error. screen-recorder-mon-feb-28-2022-12-48-23.mp4So what is the best solution?
|
@PrestaShop/product-team Could you check the @mparvazi question and give him an answer ? |
@mparvazi I hope you are okay and sorry for the delay :) |
I'm agree with option one, I'll work on it to test different situations. |
Changes: Ready for review. |
Dear @mparvazi I'm sorry it seems we forgot to add the "Waiting for QA" label so this PR has stayed here, valided from code point of view but not tested by QA and now it has to be rebased (git conflict) 😢 |