Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring #892

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Minor refactoring #892

merged 1 commit into from
Aug 2, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Aug 2, 2023 •
edited by eternoendless
Loading

Questions Answers
Description? Some minor cleanup and renaming - clarified variables in the converter class and changed availability values to constants, so it's more understandable.
Type? refacto
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Tests green. Can be merged without QA if @Robin-Fischer-PS approves. :-)

This change is Reviewable

@Robin-Fischer-PS
Copy link

Hello there,

I took a look at the code, it can indeed be merged without manual QA test :)
Thanks for the refacto @Hlavtox !

@Hlavtox Hlavtox merged commit faa9dbf into PrestaShop:dev Aug 2, 2023
12 checks passed
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Aug 2, 2023

Perfectooo

@Hlavtox Hlavtox deleted the cleanup branch August 2, 2023 20:30
@Progi1984 Progi1984 added this to the 3.13.1 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Hlavtox @Robin-Fischer-PS @M0rgan01 @Progi1984