Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySQL.php #1077

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jmarcellanlabelgrup
Copy link

Cambios para la ordenación

Questions Answers
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.
Type? bug fix / improvement / new feature / refacto / critical
BC breaks? yes / no
Deprecations? yes / no
Fixed ticket? Fixes PrestaShop/Prestashop#{issue number here}.
How to test? Please indicate how to best verify that this PR is correct.

Cambios para la ordenación
@ps-jarvis
Copy link

Hello @jmarcellanlabelgrup!

This is your first pull request on ps_facetedsearch repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello please fill in the PR body and explain your changes 😉 there is no way we can guess what you are doing here

'tableAlias' => 'psales',
'fieldName' => 'quantity',
'fieldName' => 'cantidad_vendida',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure this might work for you but this is not working for the generic usecase

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Sep 6, 2024
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block until the PR has some info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author's feedback
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

4 participants