add missing hooks when upgrading from old versions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Mar 8, 2023
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | To prevent issues with upgraded installations, we should hook this module during its upgrade. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Related to the contactform fix |
| How to test? | You'd need to have the version below < 3.3.1 installed to see that hooks are registered during an upgrade of the module. |
mflasquin
previously approved these changes
Mar 8, 2023
Hlavtox
previously approved these changes
Mar 8, 2023
florine2623
reviewed
Mar 8, 2023
There was a problem hiding this comment.
Hello @kpodemski ,
I've followed these steps :
- Uninstall ps_contactinfo
v3.3.1 - Install ps_contactinfo
v3.3.0 - Install this PR
- Upgrade to ps_contactinfo
v3.3.2 - Check in FO :
The store information block should not be hook here, am I right ?
Hlavtox
approved these changes
Mar 8, 2023
|
@florine2623 Hi, you can retest, I removed the extra hook. Krystian knows. |
mflasquin
approved these changes
Mar 8, 2023
florine2623
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Hello @Hlavtox ,
Tested and it works like a charm !
QA ✅
Thanks!
|
Thank @kpodemski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.