-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templates to reflect changes in classic theme #37
Update templates to reflect changes in classic theme #37
Conversation
ziegenberg
commented
Jun 19, 2020
Questions | Answers |
---|---|
Description? | Update templates to reflect changes in classic theme |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes PrestaShop/Prestashop#{no issue}. |
How to test? | Please check in the nav, footer and the contact us page, that all detail is shown as in the classic theme. |
…ction Signed-off-by: Daniel Ziegenberg <[email protected]>
…tinfo/nav.tpl Signed-off-by: Daniel Ziegenberg <[email protected]>
…tinfo/ps_contactinfo.tpl Signed-off-by: Daniel Ziegenberg <[email protected]>
…tinfo/ps_contactinfo-rich.tpl Signed-off-by: Daniel Ziegenberg <[email protected]>
01c7a97
to
4ec97b9
Compare
I rebased this PR onto the branch from #36, so it should be merge first. |
Hello @ziegenberg, thanks for your PR. If I understand correctly, we need to check that all the blocks you listed (nav, footer, contact-us) are still displayed correctly, like before the modification ? Thank you in advance. |
@SimonGrn yes, that's about right. This PR updates this pluings templates to the ones used integrated in ps core. So the design might change slightly. |
Thanks @ziegenberg & @sarahdib |