Add theme compatibility indication in configuration page #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,7 @@ public function getContent() | |||
| 'type' => 'switch', | |||
| 'label' => $this->trans('Display email address', array(), 'Admin.Actions'), | |||
| 'name' => 'PS_CONTACT_INFO_DISPLAY_EMAIL', | |||
| 'desc' => $this->trans('Your theme needs to be compatible with this feature', array(), 'Modules.Contactinfo.Admin'), | |||
| 'values' => array( | |||
There was a problem hiding this comment.
Hi @LouiseBonnard , I was not so sure of which translation domain to use here ?
There was a problem hiding this comment.
Will this PR add a configuration page to the 'Contact Information' module? I don't think there is any currently. If yes, you got the right domain. ;-)
There was a problem hiding this comment.
yes, we added a configuration page in another PR, and this translation will be there, it just hasn't been released yet.
Good then ! thanx
matks
approved these changes
Aug 26, 2019
|
I'm not sure this needs QA, does it ? 🤔 |
I don't think so either (and I checked the visual with @marionf) |
eternoendless
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The possibility to hide/display the merchant's email address has to be compatible with the current theme. This PR indicates this below the configuration field.