Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to be compliant with PHP 7.2.5+ #57

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Update dependencies to be compliant with PHP 7.2.5+ #57

merged 4 commits into from
Apr 16, 2021

Conversation

PierreRambaud
Copy link
Contributor

Questions Answers
Description? Use latest version of header-stamp and use PHP 7.2.5+
Type? improvement
BC breaks? no
Deprecations? no

@PierreRambaud
Copy link
Contributor Author

@Progi1984 @eternoendless Please, review and merge!

@eternoendless
Copy link
Member

Review it yourself @PierreRambaud ;)

@sowbiba
Copy link

sowbiba commented Apr 16, 2021

@Progi1984 @eternoendless Please, review and merge!

Faster!!! please

eternoendless
eternoendless approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@PierreRambaud PierreRambaud merged commit 002586a into PrestaShop:master Apr 16, 2021
@PierreRambaud PierreRambaud deleted the update/dependencies branch April 16, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternoendless eternoendless eternoendless approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PierreRambaud @eternoendless @sowbiba @Progi1984