Bind filters & pagination with url query params #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomiix
commented
May 5, 2022
atomiix
commented
| Questions | Answers |
|---|---|
| Description? | This PR aims to bind filters and pagination with the query parameters of the url so you can share the url and use the browser history to the desired filter/pagination combination. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| How to test? | Play with the filters and the pagination (page & rows per page), check that the url is updated and check that when you click the buttons "previous" or "next" of your browser, filters are updated and the list as well. |
| Possible impacts? |
matks
reviewed
May 10, 2022
matks
approved these changes
Jun 13, 2022
matthieu-rolland
approved these changes
Jun 13, 2022
|
there's no QA label for the nightly board ? |
NeOMakinG
reviewed
Jun 16, 2022
pages/index.vue
Outdated
Comment on lines
740
to
742
| if (this.pagination.descending === true) { | ||
| delete pagination.descending | ||
| } | ||
| if (this.pagination.page === 1) { | ||
| delete pagination.page | ||
| } | ||
| if (this.pagination.rowsPerPage === 20) { | ||
| delete pagination.rowsPerPage | ||
| } | ||
| if (this.pagination.sortBy === 'date') { | ||
| delete pagination.sortBy | ||
| } |
There was a problem hiding this comment.
I would invert this, in case it's not the value you want, add the property
delete can be sometime a bit expensive to use
NeOMakinG
approved these changes
Jun 16, 2022
kpodemski
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.