Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements for search widget #572

Merged

Conversation

tswfi
Copy link
Contributor

@tswfi tswfi commented Dec 20, 2023

Questions Answers
Description? Usability improvements for search widget. Focus on the input from larger area, Search by clicking on the icon (for people without enter key), use type=search to get "clear" x in the field automagically
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #543 (well at least touches on the subject ;)
Sponsor company
How to test? Click on the search widget area (but not on the input for example the search icon), focus goes to the input field (better for touch devices to have larger click area). Write something in the field, see the "x" button your browser adds by default (https://caniuse.com/input-search). Click on the icon when there is text in the field, the form is submitted and the search happens.

Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tswfi ,

Works as explained in the How to test :

Screen.Recording.2024-01-04.at.11.08.24.mov

Although I think the UX could be improved in another PR ^^

It is QA ✅

@boherm boherm merged commit 3d20f3e into PrestaShop:develop Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The click on the lens of the search box doesn't work
5 participants