Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Back to Home page' button on not-found page, fixes #554 #571

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add 'Back to Home page' button on not-found page, fixes #554 #571

merged 1 commit into from
Jan 4, 2024

Conversation

tswfi
Copy link
Contributor

@tswfi tswfi commented Dec 20, 2023

Questions Answers
Description? Add "Back to Home page" button to not-found when errorContent is defined
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #554
Sponsor company
How to test? Go to a page that is not available, see 404 page and the new "Back to Home page" button, click on the button to get back to home page

@florine2623 florine2623 self-assigned this Jan 4, 2024
florine2623
florine2623 approved these changes Jan 4, 2024
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tswfi ,

LGTM ✅

Before :
Screenshot 2024-01-04 at 10 22 26

After :
Screenshot 2024-01-04 at 10 38 08

@boherm boherm merged commit 562f517 into PrestaShop:develop Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@mflasquin mflasquin mflasquin approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a redirect button to the home page in the error page
5 participants
@tswfi @matthieu-rolland @mflasquin @florine2623 @boherm