Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smarty deprecation stripslashes #498

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

lmeyer1
Copy link
Contributor

@lmeyer1 lmeyer1 commented May 25, 2023

Questions Answers
Description? Passing stripslashes as a modifier in smarty is deprecated since Prestashop 8.0.4
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #32703
Sponsor company Société Biblique de Genève
How to test? With PS 8.0.4 and PHP 8.1 (or 8.0) we no longer get user depreation notices in the error log.

matks
matks previously requested changes May 29, 2023
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry there is a git conflict :/ you need to rebase

@lmeyer1 lmeyer1 changed the base branch from develop to master May 30, 2023 14:05
@lmeyer1 lmeyer1 changed the base branch from master to develop May 30, 2023 14:12
@lmeyer1 lmeyer1 requested a review from matks May 30, 2023 14:13
@kpodemski kpodemski added this to the Beta milestone Jun 16, 2023
@kpodemski kpodemski merged commit cdded11 into PrestaShop:develop Jun 16, 2023
@kpodemski
Copy link
Contributor

thanks @lmeyer1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

smarty user deprecation notices about php function modifiers
3 participants