Fix : [FO] FILTERING - Resize screen to mobile #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ga-devfront
commented
May 4, 2023
•
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Fix the problem of front office about filtering resize screen to mobile. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #483 |
| Sponsor company | @PrestaShopCorp. |
| How to test? | Test with the explination inside the ticket. |
ga-devfront
added
Javascript
Hlavtox
approved these changes
May 7, 2023
SharakPL
reviewed
Jul 3, 2023
| import initResponsiveToggler from './responsive-toggler'; | ||
| import initEmitter from './prestashop'; | ||
| import { | ||
| desktopElement, mobileElement, mobileElementId, contentValue, desktopElementId, | ||
| } from './constants/mocks/swapElements-data'; | ||
| import ThemeType = Theme.ThemeType; |
There was a problem hiding this comment.
@ga-devfront why this import? seems useless.
There was a problem hiding this comment.
on my side then I test without this it fail.
There was a problem hiding this comment.
Maybe this import is required elsewhere.
Is this even a valid way of importing modules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.