refactor(product): simplify code #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidglezz
commented
Apr 23, 2023
davidglezz
commented
| Questions | Answers |
|---|---|
| Description? | Make the code less verbose: |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| Sponsor company | no |
| How to test? | jest |
Signed-off-by: davidglezz <[email protected]>
boherm
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Thanks for your contribution @davidglezz, LGTM.
It can be good to simplify some TS scripts for 9.0.0 like you've done, but we must be careful that the code does not become unreadable in the future!
Hlavtox
approved these changes
Apr 24, 2023
|
Thanks @davidglezz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.