Fix weight slider breaking other sliders, fix number formatting #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jan 31, 2023
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Weight slider is not implementing number specification and the current slider implementation was not accounting for it. Also, I implemented some way of slider tooltip formatting. |
| Type? | |
| BC breaks? | |
| Deprecations? | |
| Fixed ticket? | |
| Sponsor company | |
| How to test? | Install faceted search, enable weight and price sliders in your filter template, set different weights and prices to some products in one category, visit the category. Price slider dead. |
kpodemski
approved these changes
Feb 9, 2023
|
@Hlavtox How to test it? |
|
@kpodemski Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.