Partially fix checkout tabs #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @nicosomb All good |
nicosomb
approved these changes
Jan 31, 2023
|
@Hlavtox is there a QA step for hummingbird? |
|
@nicosomb Not yet, I will discuss it with QA team to establish it. |
|
I manage to get info about steps using {Context::getContext()->controller->getCheckoutProcess()->getSteps()}, but this is very uggly. From this method, you can get title, identifier, complete, reachable and current, so in checkout-steps.tpl there can be foreach for every step with tpl including li>button with initial data from backend. Question: Is there better approach to achive this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @SharakPL Button in the breadcrumbs
(checkout-steps.tpl)is still missingactiveclass, causing buggy step switching. I don't know where to get this information.