Revert token replacement #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jan 30, 2023
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Reverts dirty token fix, it broke address forms. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | - |
|
Ping @SharakPL for merge |
|
@Hlavtox why all your jobs are red? |
|
@nicosomb |
|
@Hlavtox OK, I see. I will try contact the good person. |
|
Ping @nicosomb All good |
nicosomb
approved these changes
Jan 31, 2023
|
@Hlavtox this revert will cause some issues with the cache on product lists |
|
Yes but it broke address forms completely, we need to find a better way to do it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.