Add blockwishlist to theme.yml displayFooter #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirbel
commented
Jan 6, 2023
jirbel
commented
| Questions | Answers |
|---|---|
| Description? | Blockwishlist missing in displayFooter hook cause missing EventBus, so there is no Blockwishlist listener on fresh Hummingbird installation |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
Blockwishlist missing in displayFooter hook cause missing EventBus, so there is no Blockwishlist listener on fresh Hummingbird installation
jirbel
changed the title
Hlavtox
approved these changes
Jan 7, 2023
|
About that! IMO it shouldn't be hooked in the footer at all. Module loads its modals here and footer styles may mess them up (wrong colors on buttons and links, missing backdrop for modal, etc.). It should be hooked after footer, but it has to be done in the blockwishlist module first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.