Make blockwishlist compatible #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NeOMakinG
commented
Dec 19, 2022
NeOMakinG
commented
| Questions | Answers |
|---|---|
| Description? | Blockwishlist is not fully compatible with bootstrap 5 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Test blockwishlist inside the theme |
| Possible impacts? | Blockwishlist |
matks
reviewed
Dec 19, 2022
| @@ -0,0 +1,77 @@ | |||
| {** | |||
| * 2007-2020 PrestaShop and Contributors | |||
| @@ -0,0 +1,93 @@ | |||
| {** | |||
| * 2007-2020 PrestaShop and Contributors | |||
nicosomb
previously approved these changes
Dec 19, 2022
Damn, I took those from blockwishlist directly, I'll update them as an override is now the responsibility of the theme! |
matthieu-rolland
previously approved these changes
Dec 20, 2022
NeOMakinG
dismissed stale reviews from matthieu-rolland and nicosomb
via
c10498c
nicosomb
previously approved these changes
Dec 20, 2022
JBLach
reviewed
Jan 5, 2023
modules/blockwishlist/views/templates/components/modals/rename.tpl
Outdated
Show resolved
Hide resolved
NeOMakinG
requested review from
JBLach and
nicosomb
and removed request for
JBLach
nicosomb
previously approved these changes
Jan 5, 2023
SharakPL
previously approved these changes
Jan 5, 2023
NeOMakinG
force-pushed
the
modules-compat
branch
from
96ab6e2
to
ad47e53
Compare
NeOMakinG
force-pushed
the
modules-compat
branch
from
ad47e53
to
83be12f
Compare
nicosomb
previously approved these changes
Jan 5, 2023
SharakPL
requested changes
Jan 5, 2023
modules/blockwishlist/views/templates/components/modals/create.tpl
Outdated
Show resolved
Hide resolved
modules/blockwishlist/views/templates/components/modals/add-to-wishlist.tpl
Outdated
Show resolved
Hide resolved
modules/blockwishlist/views/templates/components/modals/create.tpl
Outdated
Show resolved
Hide resolved
modules/blockwishlist/views/templates/components/modals/login.tpl
Outdated
Show resolved
Hide resolved
modules/blockwishlist/views/templates/components/modals/rename.tpl
Outdated
Show resolved
Hide resolved
modules/blockwishlist/views/templates/components/modals/share.tpl
Outdated
Show resolved
Hide resolved
added 2 commits
January 5, 2023 16:37
|
I wish we had a linter for this |
SharakPL
approved these changes
Jan 5, 2023
kpodemski
approved these changes
Jan 5, 2023
|
🍬 @NeOMakinG :D |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.