a few small fixes that have also been made in the classic theme in progress

[JBLach]

Questions	Answers
Description?	Fixes for native modules
Type?	improvement
Fixed ticket?	#255

Module ps_brandlist -> needs to be styled and updated to bootstrap 5 I'm working on it
Module ps_supplerlist -> needs to be styled and updated to bootstrap I'm working on it

Module productcomments -> improve the appearance of buttons in the modal when we want to submit a comment
I'm working on it

Module ps_emailalerts -> improve the view on the user's page

Update

ps_brandlist, ps_supplerlist

productcomments

ps_emailalerts

from

to

[JBLach]

What do you think about changing brand and supplier pages to left column instead of full width or increasing product columns to 4 per row

now

4 columns

left-column

[JBLach]

@NeOMakinG @Hlavtox what do you think about my changes and comments? :)

[NeOMakinG]

@JBLach awesome, I'm going to review this right now

For the question, I would opt for the version with the left column but we need to make it validated by the @PrestaShop/product-team

[NeOMakinG]

Some small comments but globally looks really cool, awesome job @JBLach 🍬

[Hlavtox]

@JBLach Love everything, exceptional job dude.

As for the columns > We should automatically change from 3 to 4 product grid as you did, depending on left column being enabled or not.

And a personal taste, I would also enable left columns on brand/supplier pages by default. 👍

[eshraw]

@JBLach awesome, I'm going to review this right now

For the question, I would opt for the version with the left column but we need to make it validated by the @PrestaShop/product-team

Hello thanks @JBLach for the PR, great job !

Let's go with the left column option, it will be better for navigation and clarity !

[NeOMakinG]

@JBLach @eshraw is from the product team, you can follow his choice :)

Take the @Hlavtox comment in account about the columns sizes being adapted depending on the layout used

[Hlavtox]

On my theme (based on classic-rocket), it's done by the body class - layout-full-width, layout-left-column etc.

[JBLach]

On my theme (based on classic-rocket), it's done by the body class - layout-full-width, layout-left-column etc.

Hi, @Hlavtox how exactly would you do it, i thought about something like this

{capture assign="productClasses"}
  {if !empty($productClass)}
    {$productClass}
  {else}
    {foreach from=$page.body_classes item="class" key="layout"}
      {if $layout === 'layout-full-width'}
        {if $class}
          col-xs-6 col-xl-3
        {else}
          col-xs-6 col-xl-4
        {/if}
      {/if}
    {/foreach}
  {/if}
{/capture}

but it's probably a bad solution

[NeOMakinG]

On my theme (based on classic-rocket), it's done by the body class - layout-full-width, layout-left-column etc.

Hi, @Hlavtox how exactly would you do it, i thought about something like this

{capture assign="productClasses"}
  {if !empty($productClass)}
    {$productClass}
  {else}
    {foreach from=$page.body_classes item="class" key="layout"}
      {if $layout === 'layout-full-width'}
        {if $class}
          col-xs-6 col-xl-3
        {else}
          col-xs-6 col-xl-4
        {/if}
      {/if}
    {/foreach}
  {/if}
{/capture}

but it's probably a bad solution

@Hlavtox could you give your advice there? I would accept his solution as it looks sane even if it could be a bit more systemic, we could have an array or key/value pair that we use like $classes[$layout]

[Hlavtox]

@NeOMakinG @JBLach Guys, I am still wondering if the thing with product classes passed to the TPL was a right solution, it just feels complicated.

I just think it should be a

div .product-grid
   div. product-miniature
   div. product-miniature
   div. product-miniature

and do the sizing automatically. We can use the body classes to determine the layout and just behave according to it.

We can call about it. What is opinion of @SharakPL and @Oksydan?

[NeOMakinG]

@SharakPL wanted to rework it with grids but never started it, and I gave it a go in the past

Anyway, it shouldn't be blocking this PR at all

[SharakPL]

I still plan to make full remake of product list with grid/list switch included. But I'm going through covid 2nd time in last couple months so that's another delay. Sorry guys 😭 I hope to get it done in January...

[NeOMakinG]

I still plan to make full remake of product list with grid/list switch included. But I'm going through covid 2nd time in last couple months so that's another delay. Sorry guys 😭 I hope to get it done in January...

Yeah don't worry, but this means we can accept @JBLach PR regardless of that system

[Oksydan]

@Hlavtox I don't like relaying on body classes.
Inside template just check if $layout !== 'layouts/layout-full-width.tpl' and pass different $productClasses to product.tpl.

[kpodemski]

Thanks @JBLach 🎉