Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA : Create artifact (and release) #399

Merged
merged 11 commits into from
Dec 6, 2022

Conversation

Progi1984
Copy link
Member

Questions Answers
Description? GA : Create artifact (and release)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #361
How to test? N/A
Possible impacts? N/A

Copy link
Contributor

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the build and look fine to me 🥪

@NeOMakinG
Copy link
Contributor

@Progi1984 why do we want to target master? It will create a conflict on the develop branch

@NeOMakinG NeOMakinG changed the base branch from master to develop December 6, 2022 13:23
@NeOMakinG NeOMakinG merged commit 5781505 into PrestaShop:develop Dec 6, 2022
@Progi1984 Progi1984 deleted the ga_createArtifact branch January 31, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a build zip including assets when merging on the main branch
3 participants