Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default bootstrap colors #393

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Use default bootstrap colors #393

merged 1 commit into from
Nov 22, 2022

Conversation

NeOMakinG
Copy link
Contributor

Questions Answers
Description? We don't need to use some custom colors on our own design, we don't care as we are a default theme
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #186.
How to test? Nothing to test except that the build is working
Possible impacts? colors

nicosomb
nicosomb requested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this code is useless, why don't delete it?

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 22, 2022

@nicosomb To make developers job easier, they will know where to put it.

@Hlavtox Hlavtox merged commit ec86cea into PrestaShop:develop Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color variables needs to be reviewed
3 participants
@NeOMakinG @Hlavtox @nicosomb