Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change contact page widget to hooks #366

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Change contact page widget to hooks #366

merged 2 commits into from
Nov 10, 2022

Conversation

NeOMakinG
Copy link
Contributor

@NeOMakinG NeOMakinG commented Sep 2, 2022 •
edited
Loading

Questions Answers
Description? We want to move widgets to regular hooks to make life easier for theme developers
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#29198.
How to test? Verify that the contact page is working properly
Possible impacts? Contact page display

⚠️ need to be tested with a new version of ps_contactinfo as the current version is not compatible

@NeOMakinG NeOMakinG marked this pull request as ready for review September 2, 2022 12:48
@matks matks mentioned this pull request Oct 9, 2022
Merged
@hibatallahAouadni hibatallahAouadni self-assigned this Oct 12, 2022
hibatallahAouadni
hibatallahAouadni approved these changes Nov 10, 2022
View reviewed changes
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG

Thanks for your PR 🚀
LGTM, QA ✔️

Thanks!

@Hlavtox Hlavtox merged commit 95ef95f into PrestaShop:develop Nov 10, 2022
@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 10, 2022

Thanks @NeOMakinG!

@hibatallahAouadni hibatallahAouadni mentioned this pull request Nov 10, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all hardcoded widgets from theme
5 participants
@NeOMakinG @Hlavtox @kpodemski @hibatallahAouadni @matks